<html>
<head><meta charset="utf-8"><title>triage 2021 07 20 · t-compiler/performance · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/index.html">t-compiler/performance</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/triage.202021.2007.2020.html">triage 2021 07 20</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="246601934"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/triage%202021%2007%2020/near/246601934" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/triage.202021.2007.2020.html#246601934">(Jul 20 2021 at 14:55)</a>:</h4>
<p>(Deleted content.)</p>



<a name="246602035"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/triage%202021%2007%2020/near/246602035" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/triage.202021.2007.2020.html#246602035">(Jul 20 2021 at 14:56)</a>:</h4>
<p>Oh, wait</p>



<a name="246602118"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/triage%202021%2007%2020/near/246602118" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/triage.202021.2007.2020.html#246602118">(Jul 20 2021 at 14:57)</a>:</h4>
<p>Let me try again, this time <em>defining</em> <code>$PARENT</code></p>



<a name="246602643"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/triage%202021%2007%2020/near/246602643" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/triage.202021.2007.2020.html#246602643">(Jul 20 2021 at 15:00)</a>:</h4>
<p>okay, still not working:</p>
<div class="codehilite"><pre><span></span><code>% ( PARENT=5aff6dd07a562a2cba3c57fc3460a72acb6bef46 ; export PARENT; curl https://perf.rust-lang.org/perf/triage &quot;{&quot;start&quot;:&quot;$PARENT&quot;,&quot;stat&quot;:&quot;instructions:u&quot;}&quot; &gt; 2021-07-20.md )
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0

[1/2]: start:5aff6dd07a562a2cba3c57fc3460a72acb6bef46 --&gt; &lt;stdout&gt;
curl: (3) URL using bad/illegal format or missing URL

[2/2]: stat:instructions:u --&gt; &lt;stdout&gt;
curl: (3) URL using bad/illegal format or missing URL
</code></pre></div>



<a name="246603204"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/triage%202021%2007%2020/near/246603204" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/triage.202021.2007.2020.html#246603204">(Jul 20 2021 at 15:02)</a>:</h4>
<p>hmm, maybe that command line still needs work. (I’ll admit, my handling of variables in shell is not as fine-tuned as it used to be…)</p>



<a name="246603574"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/triage%202021%2007%2020/near/246603574" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/triage.202021.2007.2020.html#246603574">(Jul 20 2021 at 15:05)</a>:</h4>
<p>Nope, direct adaptation from readme gets same result:</p>
<div class="codehilite"><pre><span></span><code>% curl https://perf.rust-lang.org/perf/triage &#39;{&quot;start&quot;:&quot;5aff6dd07a562a2cba3c57fc3460a72acb6bef46&quot;,&quot;stat&quot;:&quot;instructions:u&quot;}&#39;

[1/2]: &quot;start&quot;:&quot;5aff6dd07a562a2cba3c57fc3460a72acb6bef46&quot; --&gt; &lt;stdout&gt;
--_curl_--&quot;start&quot;:&quot;5aff6dd07a562a2cba3c57fc3460a72acb6bef46&quot;
curl: (3) URL using bad/illegal format or missing URL

[2/2]: &quot;stat&quot;:&quot;instructions:u&quot; --&gt; &lt;stdout&gt;
--_curl_--&quot;stat&quot;:&quot;instructions:u&quot;
curl: (3) URL using bad/illegal format or missing URL
</code></pre></div>



<a name="246605188"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/triage%202021%2007%2020/near/246605188" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/triage.202021.2007.2020.html#246605188">(Jul 20 2021 at 15:15)</a>:</h4>
<p><span class="user-mention" data-user-id="224872">@rylev</span> any hints for how to resolve above ?</p>



<a name="246606535"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/triage%202021%2007%2020/near/246606535" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/triage.202021.2007.2020.html#246606535">(Jul 20 2021 at 15:25)</a>:</h4>
<p>I’m currently assuming there must be something wrong in my command line invocation, where <code>curl</code> is interpreting the input as two distinct queries to send to the website, (and where neither of the two queries is syntactically valid)</p>



<a name="246607282"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/triage%202021%2007%2020/near/246607282" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/triage.202021.2007.2020.html#246607282">(Jul 20 2021 at 15:31)</a>:</h4>
<p>Went back to weekly_report.py script, as threatened. :)</p>



<a name="246608116"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/triage%202021%2007%2020/near/246608116" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/triage.202021.2007.2020.html#246608116">(Jul 20 2021 at 15:36)</a>:</h4>
<p>That <em>looks</em> like curl is yelling at you, not the server</p>



<a name="246608157"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/triage%202021%2007%2020/near/246608157" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/triage.202021.2007.2020.html#246608157">(Jul 20 2021 at 15:36)</a>:</h4>
<p><code>curl https://perf.rust-lang.org/perf/triage -X POST -d '{"start": "9a27044f42ace9eb652781b53f598e25d4e7e918"}' &gt; triage/2021-07-13.md</code></p>



<a name="246608171"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/triage%202021%2007%2020/near/246608171" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/triage.202021.2007.2020.html#246608171">(Jul 20 2021 at 15:37)</a>:</h4>
<p>that's what I did last week I think</p>



<a name="246608182"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/triage%202021%2007%2020/near/246608182" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/triage.202021.2007.2020.html#246608182">(Jul 20 2021 at 15:37)</a>:</h4>
<p><span class="user-mention" data-user-id="116083">@pnkfelix</span> ^</p>



<a name="246608202"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/triage%202021%2007%2020/near/246608202" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/triage.202021.2007.2020.html#246608202">(Jul 20 2021 at 15:37)</a>:</h4>
<p>(maybe you could update readme once you get it working)</p>



<a name="246608317"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/triage%202021%2007%2020/near/246608317" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/triage.202021.2007.2020.html#246608317">(Jul 20 2021 at 15:38)</a>:</h4>
<p>Okay so the README is just wrong then. If I can confirm that, I’ll update the readme.</p>



<a name="246608492"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/triage%202021%2007%2020/near/246608492" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/triage.202021.2007.2020.html#246608492">(Jul 20 2021 at 15:39)</a>:</h4>
<p>hmmm. I thought I submitted a PR to fix that...</p>



<a name="246608508"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/triage%202021%2007%2020/near/246608508" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/triage.202021.2007.2020.html#246608508">(Jul 20 2021 at 15:39)</a>:</h4>
<p>I guess it got lost along the way. So sorry!</p>



<a name="246608699"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/triage%202021%2007%2020/near/246608699" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/triage.202021.2007.2020.html#246608699">(Jul 20 2021 at 15:40)</a>:</h4>
<p>You actually don't need <code>-X POST</code> that's implied by <code>-d</code></p>



<a name="246608966"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/triage%202021%2007%2020/near/246608966" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/triage.202021.2007.2020.html#246608966">(Jul 20 2021 at 15:42)</a>:</h4>
<p><code>curl https://perf.rust-lang.org/perf/triage -d '{"start":"5aff6dd07a562a2cba3c57fc3460a72acb6bef46","stat":"instructions:u"}'</code> works for me</p>



<a name="246611937"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/triage%202021%2007%2020/near/246611937" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/triage.202021.2007.2020.html#246611937">(Jul 20 2021 at 16:03)</a>:</h4>
<p>The other thing I’ll just mention: The <code>weekly_report.py</code> script gave feedback to stderr as it ran, about which commits it was comparing. The endpoint approach is just a black box as it runs. I suspect that is just something we fundamentally have to give up, if we’re using the endpoint approach. But it is something we do lose.</p>



<a name="246612183"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/triage%202021%2007%2020/near/246612183" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/triage.202021.2007.2020.html#246612183">(Jul 20 2021 at 16:05)</a>:</h4>
<p>(also, it might be nice to be able to include my username in the POST request, as another field, so that it will get automatically injected into the writeup. But that’s definitely a niche request.)</p>



<a name="246612677"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/triage%202021%2007%2020/near/246612677" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/triage.202021.2007.2020.html#246612677">(Jul 20 2021 at 16:09)</a>:</h4>
<p><span class="user-mention silent" data-user-id="116083">pnkfelix</span> <a href="#narrow/stream/247081-t-compiler.2Fperformance/topic/triage.202021.2007.2020/near/246611937">said</a>:</p>
<blockquote>
<p>The other thing I’ll just mention: The <code>weekly_report.py</code> script gave feedback to stderr as it ran, about which commits it was comparing. The endpoint approach is just a black box as it runs. I suspect that is just something we fundamentally have to give up, if we’re using the endpoint approach. But it is something we do lose.</p>
</blockquote>
<p>Yea the hope here was that the report would run much faster and that it's fine to not get feedback. It was originally running quite fast (less than a second), but it seems to have slowed. I'd like to investigate why.</p>



<a name="246615172"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/triage%202021%2007%2020/near/246615172" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> lqd <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/triage.202021.2007.2020.html#246615172">(Jul 20 2021 at 16:26)</a>:</h4>
<p><span class="user-mention silent" data-user-id="116083">pnkfelix</span> <a href="#narrow/stream/247081-t-compiler.2Fperformance/topic/triage.202021.2007.2020/near/246612183">said</a>:</p>
<blockquote>
<p>(also, it might be nice to be able to include my username in the POST request, as another field, so that it will get automatically injected into the writeup. But that’s definitely a niche request.)</p>
</blockquote>
<p>just sed it with your curl command: <code>sed 's/by \*\*@???\*\*/by **@your_name**/'</code></p>



<a name="246617224"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/triage%202021%2007%2020/near/246617224" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/triage.202021.2007.2020.html#246617224">(Jul 20 2021 at 16:42)</a>:</h4>
<p>I guess that works too. Not 100% robust as what I pictured, but its hard to imagine the template output changing in a way that would cause that to fail. (Maybe if PR titles include a <code>by \*\*@???\*\*</code>…). And, as a plus, it would be completely independent of the endpoint internal implementation. Decoupling is good.</p>



<a name="246617330"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/triage%202021%2007%2020/near/246617330" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/triage.202021.2007.2020.html#246617330">(Jul 20 2021 at 16:43)</a>:</h4>
<p>Though to be honest, if I were to do that, I’d probably invest effort in a <em>new</em> driver script still used the endpoint, but automatically looked up the PARENT commit id (and post-processed output to inject my username, <em>et cetera</em>)</p>



<a name="246619932"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/triage%202021%2007%2020/near/246619932" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/triage.202021.2007.2020.html#246619932">(Jul 20 2021 at 17:04)</a>:</h4>
<p>we should be able to auto compute endpoint from the previous run (querying the file via github or so)</p>



<a name="246620371"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/triage%202021%2007%2020/near/246620371" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/triage.202021.2007.2020.html#246620371">(Jul 20 2021 at 17:07)</a>:</h4>
<p>We could do this in the endpoint itself.</p>



<a name="246620412"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/triage%202021%2007%2020/near/246620412" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/triage.202021.2007.2020.html#246620412">(Jul 20 2021 at 17:07)</a>:</h4>
<p>right, that was what I wanted to say</p>



<a name="246636838"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/triage%202021%2007%2020/near/246636838" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/triage.202021.2007.2020.html#246636838">(Jul 20 2021 at 19:24)</a>:</h4>
<p>What is the section entitled " Untriaged Pull Requests” ?</p>



<a name="246636892"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/triage%202021%2007%2020/near/246636892" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/triage.202021.2007.2020.html#246636892">(Jul 20 2021 at 19:24)</a>:</h4>
<p>Are those PR’s that couldn’t have performance comparisons done on them?</p>



<a name="246670937"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/triage%202021%2007%2020/near/246670937" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/triage.202021.2007.2020.html#246670937">(Jul 21 2021 at 01:45)</a>:</h4>
<p>filed as PR <a href="https://github.com/rust-lang/rustc-perf/pull/930">https://github.com/rust-lang/rustc-perf/pull/930</a></p>



<a name="246670949"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/triage%202021%2007%2020/near/246670949" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/triage.202021.2007.2020.html#246670949">(Jul 21 2021 at 01:45)</a>:</h4>
<p>(Note: I didn’t do <em>anything</em> about the “untriaged pull requests” section.)</p>



<a name="246670960"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/triage%202021%2007%2020/near/246670960" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/triage.202021.2007.2020.html#246670960">(Jul 21 2021 at 01:45)</a>:</h4>
<p>(I just want to be done with this task.)</p>



<a name="246685647"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/triage%202021%2007%2020/near/246685647" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> lqd <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/triage.202021.2007.2020.html#246685647">(Jul 21 2021 at 06:59)</a>:</h4>
<p><span class="user-mention" data-user-id="116083">@pnkfelix</span>  IIUC the untriaged PRs are the ones where a perf run was done before it landed, came back as a regression and was marked as such by the bot, but was not then triaged and marked as a "justified regression" by the authors/reviewers (using the perf-regression-triaged label)</p>



<a name="246687192"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/triage%202021%2007%2020/near/246687192" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> lqd <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/triage.202021.2007.2020.html#246687192">(Jul 21 2021 at 07:22)</a>:</h4>
<p>(just like we see good perf runs that don’t always end up being wins after the PR lands, the perf runs marked as regressions can end up regressing less or not at all when landing — maybe in these latter cases the bot could automatically mark the PR triaged when the final results differ from the expectation ? And/or comment with the final perf results, on all PRs after they land)</p>



<a name="246693515"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/triage%202021%2007%2020/near/246693515" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/triage.202021.2007.2020.html#246693515">(Jul 21 2021 at 08:47)</a>:</h4>
<p>What <span class="user-mention" data-user-id="116113">@lqd</span> said is mostly right though, it's the expectation that we also add perf-regression to any PRs where the regression was found _after_ merging as well.</p>



<a name="246693833"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/triage%202021%2007%2020/near/246693833" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/triage.202021.2007.2020.html#246693833">(Jul 21 2021 at 08:51)</a>:</h4>
<p>Essentially the <code>perf-regression</code> label is used to indicate that the latest known performance state of the PR is a regression. <code>perf-regression-triaged</code> is the label applied when _something_ has been done to address the performance issue. This can be one of several things:</p>
<ul>
<li>An issue has been created to address the performance issue (linking to the original PR)</li>
<li>The author and reviewer have determined that the change in the PR is worth the regression (e.g., a correctness fix - better to be slow and correct than fast and wrong)</li>
<li>The regression isn't actually a regression (i.e., there's something wrong with perf.rlo) - this should be accompanied by an issue on rustc-perf</li>
<li>Another PR has been opened that fixes the perf regression (with a link)</li>
</ul>



<a name="246693967"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/triage%202021%2007%2020/near/246693967" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/triage.202021.2007.2020.html#246693967">(Jul 21 2021 at 08:53)</a>:</h4>
<p>(sorry <span class="user-mention" data-user-id="116083">@pnkfelix</span>  for the confusion here - we've been discussion this in Zulip but I don't believe I explicitly pinged you on this). This needs to be documented somewhere. We could put it in the triage README, but this goes beyond the triage process and is really just the perf process in general. Perhaps a dedicated README for the process as a whole is warranted...</p>



<a name="246694082"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/triage%202021%2007%2020/near/246694082" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/triage.202021.2007.2020.html#246694082">(Jul 21 2021 at 08:54)</a>:</h4>
<p>As for what to do about the untriaged PRs - we're unsure. <span class="user-mention" data-user-id="116122">@simulacrum</span> wanted to wait a bit to see what happens with them. I imagine the list will continue growing, and we'll need a process for pinging the author/reviewer to address the perf-regression in some way (one of the ways listed above)</p>



<a name="246694977"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/triage%202021%2007%2020/near/246694977" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/triage.202021.2007.2020.html#246694977">(Jul 21 2021 at 09:05)</a>:</h4>
<p><span class="user-mention" data-user-id="116083">@pnkfelix</span> also I think you may have missed that we now mark noisy benchmarks with "?" based on historical data. It's a good thing to eyeball the data yourself to make sure you agree with that assessment, but the idea is that we want to be able to make automated decisions based on perf results and having an accurate way to label benchmarks as noisy is essential for that.</p>



<a name="246706760"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/triage%202021%2007%2020/near/246706760" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/triage.202021.2007.2020.html#246706760">(Jul 21 2021 at 11:32)</a>:</h4>
<p>I did see that a PR landed to do marking “?” based on historical data. Do we still have “??” vs “?”, or is there just “?” now?</p>



<a name="246708806"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/triage%202021%2007%2020/near/246708806" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> lqd <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/triage.202021.2007.2020.html#246708806">(Jul 21 2021 at 11:56)</a>:</h4>
<p>(I don't think "??" still exists)</p>



<a name="246709446"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/triage%202021%2007%2020/near/246709446" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/triage.202021.2007.2020.html#246709446">(Jul 21 2021 at 12:03)</a>:</h4>
<p>"??" no longer exists. I'd like to continue to evolve how we handle noisy data as it's a bit too much of a simplification to just mark a benchmark as noisy and be done with it.</p>



<a name="246709843"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/triage%202021%2007%2020/near/246709843" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> lqd <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/triage.202021.2007.2020.html#246709843">(Jul 21 2021 at 12:07)</a>:</h4>
<p>maybe we could show the variance info (say on a tooltip) on a result with "?" with a similar message as before ? it was something like "this benchmark is highly variable, don't trust it"; like "coercions-debug incr-patched: println" is marked as "highly variable" and there are a handful of "noisy" ones, and it would be nice to at least see this categorization on the page</p>



<a name="246802789"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/triage%202021%2007%2020/near/246802789" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/triage.202021.2007.2020.html#246802789">(Jul 22 2021 at 02:26)</a>:</h4>
<p>I realized that I failed to follow through on some of the steps here, namely the TWIR update. I’m looking into it now.</p>



<a name="246803427"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/triage%202021%2007%2020/near/246803427" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/triage.202021.2007.2020.html#246803427">(Jul 22 2021 at 02:43)</a>:</h4>
<p>okay, TWIR and T-compiler agenda are both updated. Thanks y’all!</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>